Allow swap_dims to take kwargs#4841
Merged
max-sixty merged 1 commit intopydata:masterfrom Jan 24, 2021
Merged
Conversation
andersy005
approved these changes
Jan 24, 2021
keewis
reviewed
Jan 25, 2021
Collaborator
There was a problem hiding this comment.
I think we need a few more changes to the docstrings, sorry for being a bit slow with the review. Also, we usually have the pattern of coords / coords_kwargs which makes dims_dict seem a bit out of place. Should we deprecate it in favor of dims? This currently has a conflict with this:
Line 3246 in a0c71c1
but I think we can just call that
variable_dims
| Dictionary whose keys are current dimension names and whose values | ||
| are new names. | ||
|
|
||
| **dim_kwargs : {existing_dim: new_dim, ...}, optional |
Collaborator
There was a problem hiding this comment.
Suggested change
| **dim_kwargs : {existing_dim: new_dim, ...}, optional | |
| **dims_kwargs : {existing_dim: new_dim, ...}, optional |
| Dictionary whose keys are current dimension names and whose values | ||
| are new names. | ||
|
|
||
| **dim_kwargs : {dim: , ...}, optional |
Collaborator
There was a problem hiding this comment.
Suggested change
| **dim_kwargs : {dim: , ...}, optional | |
| **dims_kwargs : {existing_dim: new_dim, ...}, optional |
dcherian
added a commit
to TomNicholas/xarray
that referenced
this pull request
Jan 29, 2021
* master: WIP: backend interface, now it uses subclassing (pydata#4836) weighted: small improvements (pydata#4818) Update related-projects.rst (pydata#4844) iris update doc url (pydata#4845) Faster unstacking (pydata#4746) Allow swap_dims to take kwargs (pydata#4841) Move skip ci instructions to contributing guide (pydata#4829) fix issues in drop_sel and drop_isel (pydata#4828)
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Jan 29, 2021
* upstream/master: speed up the repr for big MultiIndex objects (pydata#4846) dim -> coord in DataArray.integrate (pydata#3993) WIP: backend interface, now it uses subclassing (pydata#4836) weighted: small improvements (pydata#4818) Update related-projects.rst (pydata#4844) iris update doc url (pydata#4845) Faster unstacking (pydata#4746) Allow swap_dims to take kwargs (pydata#4841) Move skip ci instructions to contributing guide (pydata#4829) fix issues in drop_sel and drop_isel (pydata#4828) Bugfix in list_engine (pydata#4811) Add drop_isel (pydata#4819) Fix RST. Remove the references to `_file_obj` outside low level code paths, change to `_close` (pydata#4809)
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Feb 3, 2021
* master: (458 commits) Add units if "unit" is in the attrs. (pydata#4850) speed up the repr for big MultiIndex objects (pydata#4846) dim -> coord in DataArray.integrate (pydata#3993) WIP: backend interface, now it uses subclassing (pydata#4836) weighted: small improvements (pydata#4818) Update related-projects.rst (pydata#4844) iris update doc url (pydata#4845) Faster unstacking (pydata#4746) Allow swap_dims to take kwargs (pydata#4841) Move skip ci instructions to contributing guide (pydata#4829) fix issues in drop_sel and drop_isel (pydata#4828) Bugfix in list_engine (pydata#4811) Add drop_isel (pydata#4819) Fix RST. Remove the references to `_file_obj` outside low level code paths, change to `_close` (pydata#4809) fix decode for scale/ offset list (pydata#4802) Expand user dir paths (~) in open_mfdataset and to_zarr. (pydata#4795) add a version info step to the upstream-dev CI (pydata#4815) fix the ci trigger action (pydata#4805) scatter plot by order of the first appearance of hue (pydata#4723) ...
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pre-commit run --all-fileswhats-new.rst