Add release summary, some touch-ups#4217
Merged
dcherian merged 4 commits intopydata:masterfrom Jul 23, 2020
Merged
Conversation
keewis
reviewed
Jul 12, 2020
Collaborator
keewis
left a comment
There was a problem hiding this comment.
Looks good to me, too. I have a few suggestions, though:
HOW_TO_RELEASE.md
Outdated
Comment on lines
+15
to
+16
| I (@max) find it helpful to use a PR given I'm not always familiar with all the | ||
| features of the release, and the summary is distributed widely. |
Collaborator
There was a problem hiding this comment.
I think it definitely makes sense to get a review of the summary so I'd remove this.
Instead, I'd like to suggest writing the summary as item 2, then opening a PR with the contributors, the summary and the whats-new.rst fixes (new item 4) as item 5 to get a chance for a review and once that is merged continue with the current item 4 (after syncing again).
So now we'd have:
- sync branch
- write summary
- get the contributors (also: what should happen in the rare case that the one releasing is not included in that list?)
- check
whats-new.rstand the docs - open a PR to add items 2 to 4 to
whats-new.rst - resync (should that be a new step or should that also be in item 5?)
- continue with the old item 4
Does that make sense?
Collaborator
Author
|
Updated based on @keewis good suggestions. I haven't updated the numbers until we agree it's correct. (Maybe there's some plugin to do this? Lucky we don't have a 100 item list...) |
dcherian
approved these changes
Jul 13, 2020
Contributor
|
Thanks @max-sixty |
dcherian
added a commit
to jacobtomlinson/xarray
that referenced
this pull request
Jul 24, 2020
* upstream/master: Added xarrays-spatial and updated geoviews link (pydata#4262) update docs to point to xarray-contrib and xarray-tutorial (pydata#4252) Add release summary, some touch-ups (pydata#4217) CFTimeIndex calendar in repr (pydata#4092) fix the RTD timeouts (pydata#4254) update isort CI and pre-commit hook (pydata#4204)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: