Skip to content

fixes #4706 -- don't internal error on corrupt private key #5307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reaperhulk merged 2 commits into from
Aug 15, 2020
Merged

fixes #4706 -- don't internal error on corrupt private key #5307

reaperhulk merged 2 commits into from
Aug 15, 2020

Conversation

@alex
Copy link
Member

@alex alex commented Jul 12, 2020

No description provided.

@alex alex linked an issue Jul 12, 2020 that may be closed by this pull request
Internal assertion error on some corrupt private keys #4706
Closed
@alex alex added this to the Thirtieth release milestone Jul 12, 2020
@alex alex force-pushed the rsa-inernal-error branch 7 times, most recently from 4716185 to 4f3f621 Compare July 18, 2020 17:16
@alex
Copy link
Member Author

alex commented Jul 18, 2020

@reaperhulk so I updated this PR to simply check for key validity on load... this breaks the twisted and paramiko tests :-(

@alex
Copy link
Member Author

alex commented Jul 18, 2020

Ok, paramiko issue is: paramiko/paramiko#1723

@alex alex force-pushed the rsa-inernal-error branch 2 times, most recently from 385967f to 6dcbf57 Compare July 18, 2020 18:26
@alex
Copy link
Member Author

alex commented Jul 18, 2020

And the twisted issue: twisted/twisted#1355

@alex alex force-pushed the rsa-inernal-error branch from 6dcbf57 to 4f3f621 Compare July 18, 2020 20:50
@alex alex force-pushed the rsa-inernal-error branch from 671299c to 79b5f32 Compare July 20, 2020 18:09
@alex alex force-pushed the rsa-inernal-error branch from 79b5f32 to 33afdda Compare August 15, 2020 15:39
@opendev-zuul
Copy link

opendev-zuul bot commented Aug 15, 2020

Build succeeded (check pipeline).

@reaperhulk reaperhulk merged commit fce9a79 into pyca:master Aug 15, 2020
@alex alex deleted the rsa-inernal-error branch August 15, 2020 16:52
@reaperhulk reaperhulk mentioned this pull request Aug 27, 2020
Closed
@angelakis angelakis mentioned this pull request Aug 28, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

Thirty first release

Development

Successfully merging this pull request may close these issues.

Internal assertion error on some corrupt private keys

2 participants

@alex @reaperhulk