Skip to content

Enable voltage as a state#957

Open
NicolaCourtier wants to merge 1 commit into
developfrom
voltage-as-a-state
Open

Enable voltage as a state#957
NicolaCourtier wants to merge 1 commit into
developfrom
voltage-as-a-state

Conversation

@NicolaCourtier

Copy link
Copy Markdown
Member

Description

Fix the failing dependency tests by enabling the "voltage as a state" option for the pybop.lithium_ion models.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #).

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: $ pre-commit run or $ nox -s pre-commit (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctest
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@NicolaCourtier

Copy link
Copy Markdown
Member Author

Some tests are failing for unrelated reasons. As long as this one passes the unit tests, I think we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly latest dependencies unit tests failed (macos-latest Python 3.13) Nightly latest dependencies unit tests failed (ubuntu-latest Python 3.13)

1 participant