Skip to content

i703: fixes for pybamm v25.4#705

Merged
BradyPlanden merged 3 commits into
developfrom
703-bug-fixes-for-pybamm-v254
Apr 4, 2025
Merged

i703: fixes for pybamm v25.4#705
BradyPlanden merged 3 commits into
developfrom
703-bug-fixes-for-pybamm-v254

Conversation

@BradyPlanden

@BradyPlanden BradyPlanden commented Apr 4, 2025

Copy link
Copy Markdown
Member

Description

This PR completes the following:

  • bugfix fitting_problem output for calc_grad under fail conditions
  • adds fixed numpy random seed for pytest framework
  • updates to IDAKLU where beneficial
  • updates the CI matrix to remove macos-13 examples + integration.
  • removes duplicated macos-14 integration tests from CI

Issue reference

Fixes #703

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

…ns, adds fixed numpy random seed for pytest framework, updates to IDAKLU where beneficial
@BradyPlanden BradyPlanden linked an issue Apr 4, 2025 that may be closed by this pull request
@codecov

codecov Bot commented Apr 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (0a55c30) to head (5f13c46).
Report is 17 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #705   +/-   ##
========================================
  Coverage    99.22%   99.22%           
========================================
  Files           68       68           
  Lines         4922     4925    +3     
========================================
+ Hits          4884     4887    +3     
  Misses          38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agriyakhetarpal agriyakhetarpal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @BradyPlanden! This looks good to me, with two comments.

Comment thread .github/workflows/test_on_pull_request.yaml Outdated
Comment thread .github/workflows/test_on_pull_request.yaml
Comment thread conftest.py
@agriyakhetarpal

Copy link
Copy Markdown
Member

We probably won't need to set the solver to IDAKLU explicitly once pybamm-team/PyBaMM#4915 makes it to a release.

Comment thread pybop/problems/fitting_problem.py Outdated

@NicolaCourtier NicolaCourtier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, thanks @BradyPlanden !

@BradyPlanden BradyPlanden merged commit de4a5c9 into develop Apr 4, 2025
@BradyPlanden BradyPlanden deleted the 703-bug-fixes-for-pybamm-v254 branch April 4, 2025 18:25
BradyPlanden added a commit that referenced this pull request Apr 25, 2025
* feat: bugfix fitting_problem output for calc_grad under fail conditions, adds fixed numpy random seed for pytest framework, updates to IDAKLU where beneficial

* CI: removes macos-13 examples, duplicate macos-14 integration

* refactor: fitting_problem.py updates, add changelog entry, removes macos-13 integration from CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Depreciate integration & example tests on CI for Apple Intel platform [Bug]: Fixes for pybamm v25.4

3 participants