i703: fixes for pybamm v25.4#705
Merged
Merged
Conversation
…ns, adds fixed numpy random seed for pytest framework, updates to IDAKLU where beneficial
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #705 +/- ##
========================================
Coverage 99.22% 99.22%
========================================
Files 68 68
Lines 4922 4925 +3
========================================
+ Hits 4884 4887 +3
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agriyakhetarpal
approved these changes
Apr 4, 2025
agriyakhetarpal
left a comment
Member
There was a problem hiding this comment.
Thanks, @BradyPlanden! This looks good to me, with two comments.
Member
|
We probably won't need to set the solver to IDAKLU explicitly once pybamm-team/PyBaMM#4915 makes it to a release. |
NicolaCourtier
approved these changes
Apr 4, 2025
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Just one comment, thanks @BradyPlanden !
…cos-13 integration from CI
BradyPlanden
added a commit
that referenced
this pull request
Apr 25, 2025
* feat: bugfix fitting_problem output for calc_grad under fail conditions, adds fixed numpy random seed for pytest framework, updates to IDAKLU where beneficial * CI: removes macos-13 examples, duplicate macos-14 integration * refactor: fitting_problem.py updates, add changelog entry, removes macos-13 integration from CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR completes the following:
macos-13examples + integration.macos-14integration tests from CIIssue reference
Fixes #703
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.