Adds FittingProblem arg for model rebuild on evaluation, DFN examples and data-generation scripts#663
Conversation
…Problem, synthetic data generation
…nerated data, adds dfn pulse fit example
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #663 +/- ##
========================================
Coverage 99.21% 99.21%
========================================
Files 67 67
Lines 4834 4842 +8
========================================
+ Hits 4796 4804 +8
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
initial_state into FittingProblem, adds DFN examples and data-generation scriptsFittingProblem arg for model rebuild on evaluation, DFN examples and data-generation scripts
…tring and changelog entries
# Conflicts: # CHANGELOG.md # examples/scripts/comparison_examples/adamw.py # examples/scripts/comparison_examples/irpropmin.py # examples/scripts/comparison_examples/maximum_likelihood.py # examples/scripts/getting_started/ask-tell-interface.py # pybop/optimisers/base_optimiser.py
# Conflicts: # examples/scripts/comparison_examples/adamw.py
martinjrobins
left a comment
There was a problem hiding this comment.
thanks @BradyPlanden, looks good to me :)
|
Thanks for these additions @BradyPlanden! It seems to me that the safe option would be to set |
|
Thanks for the review/comments @martinjrobins @NicolaCourtier! I've removed the extra |
Description
Completes the following:
model.predictoutput for discontinuities that occur from multi-step experiments (this currently causes large issues with the interpolated IDAKLU)Issue reference
Fixes #662
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.