Skip to content

Enable domain-based means#659

Merged
NicolaCourtier merged 61 commits into
developfrom
non-uniform-mean
Mar 25, 2025
Merged

Enable domain-based means#659
NicolaCourtier merged 61 commits into
developfrom
non-uniform-mean

Conversation

@NicolaCourtier

@NicolaCourtier NicolaCourtier commented Feb 4, 2025

Copy link
Copy Markdown
Member

Description

For the fitting costs which involve a taking a mean, enable this average to be weighted by the spacing of the (time) domain data or a custom weighting.

Issue reference

Show feature

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@codecov

codecov Bot commented Feb 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.21%. Comparing base (f4cc252) to head (26b50c0).
Report is 30 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #659   +/-   ##
========================================
  Coverage    99.21%   99.21%           
========================================
  Files           67       67           
  Lines         4834     4842    +8     
========================================
+ Hits          4796     4804    +8     
  Misses          38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from fix-cost-gradients to develop February 16, 2025 21:08
@NicolaCourtier NicolaCourtier changed the base branch from develop to problem-cost-interface February 18, 2025 09:46
Base automatically changed from problem-cost-interface to develop February 25, 2025 11:19
@NicolaCourtier NicolaCourtier marked this pull request as ready for review February 25, 2025 11:27

@MarkBlyth MarkBlyth left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with all of this, can't spot anything that needs changing!

@NicolaCourtier NicolaCourtier merged commit 1bad045 into develop Mar 25, 2025
@NicolaCourtier NicolaCourtier deleted the non-uniform-mean branch March 25, 2025 15:12
@NicolaCourtier NicolaCourtier moved this to Done in v25.3 Mar 25, 2025
@NicolaCourtier NicolaCourtier mentioned this pull request Mar 28, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants