Skip to content

Bug fix GroupedSPMe to enable experiments#592

Merged
NicolaCourtier merged 65 commits into
developfrom
grouped-SPMe
Dec 11, 2024
Merged

Bug fix GroupedSPMe to enable experiments#592
NicolaCourtier merged 65 commits into
developfrom
grouped-SPMe

Conversation

@NicolaCourtier

Copy link
Copy Markdown
Member

Description

Introduces separate variable names for the internal and output variables representing the particle surface voltages. Many thanks to @noelhallemans for spotting this and @martinjrobins for debugging it!

Issue reference

Fix following #584

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@codecov

codecov Bot commented Dec 11, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (c8b00e6) to head (c2eef53).
Report is 106 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #592      +/-   ##
===========================================
+ Coverage    99.08%   99.22%   +0.13%     
===========================================
  Files           52       57       +5     
  Lines         3605     4240     +635     
===========================================
+ Hits          3572     4207     +635     
  Misses          33       33              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@NicolaCourtier
NicolaCourtier merged commit 1095016 into develop Dec 11, 2024
@NicolaCourtier
NicolaCourtier deleted the grouped-SPMe branch December 11, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants