Default solver from Casadi to IDAKLU#546
Merged
Merged
Conversation
…es Casadi solver.
…ed_kalman_filter.py
…erances where required, removes redundant non-convergence test
90efafb to
2d4dcb1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #546 +/- ##
========================================
Coverage 99.22% 99.22%
========================================
Files 68 68
Lines 4922 4926 +4
========================================
+ Hits 4884 4888 +4
Misses 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agriyakhetarpal
approved these changes
Apr 23, 2025
agriyakhetarpal
left a comment
Member
There was a problem hiding this comment.
Thanks, @BradyPlanden! I think we should also bump
Line 29 in 66cf26c
>=25.4.1, as pybamm-team/PyBaMM#4915 first made it to that release.
BradyPlanden
added a commit
that referenced
this pull request
Apr 25, 2025
* fix: removes default solver Casadi args, adds catch for EIS and applies Casadi solver. * examples: removes IDAKLU explicit definition, adds Casadi for unscented_kalman_filter.py * tests: removes general explicit IDAKLU definition, adds increased tolerances where required, removes redundant non-convergence test * coverage: adds explicit solver arg for ExponentialDecay * increment pybamm version, add changlog entry * infra: update nox sessions to upgrade dependencies by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the required changes for PyBaMM's switch to the IDAKLU solver as default.
This relates to PyBAMM's #4545, where the CasadiSolver's explicit sensitivity functional is planned to be depreciated.
Issue reference
Fixes # (issue-number)
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.