Skip to content

Adds ScaledLogLikelihood Class#541

Merged
BradyPlanden merged 3 commits into
developfrom
540-add-scaledloglikelihood-class
Oct 31, 2024
Merged

Adds ScaledLogLikelihood Class#541
BradyPlanden merged 3 commits into
developfrom
540-add-scaledloglikelihood-class

Conversation

@BradyPlanden

Copy link
Copy Markdown
Member

Description

Adds a ScaledLogLikelihood class, alongside a base meta likelihood class to reduce code duplication.

Issue reference

Fixes #540

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@BradyPlanden BradyPlanden linked an issue Oct 30, 2024 that may be closed by this pull request
@BradyPlanden BradyPlanden added the show This PR will be merged without review label Oct 31, 2024
@codecov

codecov Bot commented Oct 31, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (c8b00e6) to head (61a26d7).
Report is 81 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #541      +/-   ##
===========================================
+ Coverage    99.08%   99.12%   +0.03%     
===========================================
  Files           52       55       +3     
  Lines         3605     3869     +264     
===========================================
+ Hits          3572     3835     +263     
- Misses          33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden merged commit 3fc7dbf into develop Oct 31, 2024
@BradyPlanden BradyPlanden deleted the 540-add-scaledloglikelihood-class branch October 31, 2024 10:44
BradyPlanden added a commit that referenced this pull request Nov 25, 2024
* feat: adds ScaledLogLikelihood Class

* fix: ignore unknown status code (999), add changelog entry

* refactor: ScaledLogLikelihood, update docstrings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

show This PR will be merged without review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add ScaledLogLikelihood class

1 participant