Skip to content

Fixes for LogPosterior w/ GaussianLogLikelihood#505

Merged
BradyPlanden merged 5 commits into
developfrom
bugfixes-for-logposterior-transformations
Sep 17, 2024
Merged

Fixes for LogPosterior w/ GaussianLogLikelihood#505
BradyPlanden merged 5 commits into
developfrom
bugfixes-for-logposterior-transformations

Conversation

@BradyPlanden

@BradyPlanden BradyPlanden commented Sep 16, 2024

Copy link
Copy Markdown
Member

Description

Bug fixes for LogPosterior to integrate with transformed GaussianLogLikelihood.

Issue reference

Fixes # (issue-number)

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@codecov

codecov Bot commented Sep 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (ed457ff) to head (4f926ef).
Report is 113 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #505   +/-   ##
========================================
  Coverage    99.04%   99.04%           
========================================
  Files           52       52           
  Lines         3559     3560    +1     
========================================
+ Hits          3525     3526    +1     
  Misses          34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden marked this pull request as ready for review September 17, 2024 07:44
f"Sigma for output {index+1}",
initial_value=value,
prior=Uniform(0.5 * value, 1.5 * value),
prior=Uniform(1e-3 * value, 1e3 * value),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is extended to ensure the logpdf of the uniform prior is finite across the search space.

@martinjrobins martinjrobins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good @BradyPlanden, just a comment for a fix on the posterior class (which to be fair existed before this PR!)

Comment thread pybop/costs/_likelihoods.py
@BradyPlanden BradyPlanden merged commit 764bfb0 into develop Sep 17, 2024
@BradyPlanden BradyPlanden deleted the bugfixes-for-logposterior-transformations branch September 17, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants