Transformation fixes#495
Conversation
…st transformation arg in scipy_optimisers.py, updates transformation integration tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #495 +/- ##
========================================
Coverage 99.04% 99.04%
========================================
Files 52 52
Lines 3556 3559 +3
========================================
+ Hits 3522 3525 +3
Misses 34 34 ☔ View full report in Codecov by Sentry. |
martinjrobins
left a comment
There was a problem hiding this comment.
Thanks @BradyPlanden, looks great. I think there is a danger in the lenght of the fail gradient becoming out of sync with the number of parameters in the base cost class, so would suggest a setter on the parameters attribute, what do you think? Can be a separate issue as well if you don't want to deal with it now
|
Thanks for the review @martinjrobins, I agree that a setter in the |
… call to parameters.join(). Updts. fail_gradient within setter.
…r-gaussianloglikelihood
…uild()` initial_state dict keys to docstring
martinjrobins
left a comment
There was a problem hiding this comment.
Yea, I think this is better. Should parameters be renamed to `_parameters' to indicate that it shouldn't be set directly?
Description
apply_transformarg in cost call for SciPy optimisers. Adds addition costs to transformation integration tests and general refactor.Issue reference
Fixes #492
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.