Skip to content

Add model.clear and remove setters#448

Merged
NicolaCourtier merged 1 commit into
developfrom
445-remove-setters
Aug 7, 2024
Merged

Add model.clear and remove setters#448
NicolaCourtier merged 1 commit into
developfrom
445-remove-setters

Conversation

@NicolaCourtier

Copy link
Copy Markdown
Member

Description

Fixes unintended consequences of ruff linting.

Issue reference

Fixes #445

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@NicolaCourtier
NicolaCourtier marked this pull request as ready for review August 7, 2024 14:24
@codecov

codecov Bot commented Aug 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (d68a70d) to head (605f509).
Report is 494 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #448      +/-   ##
===========================================
+ Coverage    98.51%   98.53%   +0.02%     
===========================================
  Files           46       46              
  Lines         2960     2941      -19     
===========================================
- Hits          2916     2898      -18     
+ Misses          44       43       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment on the solver setter.

Comment thread pybop/models/base_model.py
@NicolaCourtier
NicolaCourtier merged commit a8dbbe6 into develop Aug 7, 2024
@NicolaCourtier
NicolaCourtier deleted the 445-remove-setters branch August 7, 2024 15:53
BradyPlanden pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor BaseModel property setters

2 participants