Add nbstripout pre-commit hook#428
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
========================================
Coverage 98.14% 98.14%
========================================
Files 44 44
Lines 2697 2697
========================================
Hits 2647 2647
Misses 50 50 ☔ View full report in Codecov by Sentry. |
|
Note that the failed project coverage check is simply due to the extra Changelog entry. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
These changes LGTM in principle; thank you, @NicolaCourtier!
BradyPlanden
left a comment
There was a problem hiding this comment.
This looks great, thanks @NicolaCourtier! The patch coverage is down due to this flaky test: https://app.codecov.io/gh/pybop-team/PyBOP/pull/428/indirect-changes which I've fixed in #411:
PyBOP/tests/unit/test_optimisation.py
Line 427 in 7bae73c
I've left a few comments/suggestions, otherwise LGTM.
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
Description
Add the nbstripout pre-commit hook from: https://github.com/kynan/nbstripout
Issue reference
Fixes #427
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.