Skip to content

General additions ahead of v24.6#393

Merged
BradyPlanden merged 6 commits into
developfrom
fixes-ahead-v24.6
Jul 8, 2024
Merged

General additions ahead of v24.6#393
BradyPlanden merged 6 commits into
developfrom
fixes-ahead-v24.6

Conversation

@BradyPlanden

Copy link
Copy Markdown
Member

Description

Fixes ahead of v24.6 based around failing scheduled tests located here.

Issue reference

Fixes # (issue-number)

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@codecov

codecov Bot commented Jul 5, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.78%. Comparing base (86a297a) to head (50bd26d).
Report is 666 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #393   +/-   ##
========================================
  Coverage    97.78%   97.78%           
========================================
  Files           43       43           
  Lines         2574     2579    +5     
========================================
+ Hits          2517     2522    +5     
  Misses          57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread CHANGELOG.md Outdated
Comment thread tests/integration/test_spm_parameterisations.py Outdated

@NicolaCourtier NicolaCourtier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these additions @BradyPlanden !

Comment thread examples/scripts/cuckoo.py Outdated
Comment thread examples/scripts/cuckoo.py Outdated
@BradyPlanden BradyPlanden merged commit 64f635e into develop Jul 8, 2024
@BradyPlanden BradyPlanden deleted the fixes-ahead-v24.6 branch July 8, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants