Adds Minkowski and SumofPower Cost#383
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #383 +/- ##
===========================================
+ Coverage 97.88% 98.02% +0.14%
===========================================
Files 43 43
Lines 2598 2632 +34
===========================================
+ Hits 2543 2580 +37
+ Misses 55 52 -3 ☔ View full report in Codecov by Sentry. |
BradyPlanden
commented
Jul 1, 2024
eae7d67 to
43cfcb5
Compare
BradyPlanden
commented
Jul 5, 2024
…ze, refactor docstring / inf_count
…meterisation's max_unchanged_iterations setting
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Hi @BradyPlanden, a few comments for you to go through, but overall it's looking good. I'll just upload some minor edits to the text of the example notebook.
NicolaCourtier
approved these changes
Jul 15, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Great, thanks @BradyPlanden !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an implementation of Minkowski Loss, with tests and example usage.
Issue reference
Fixes #382
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.