Add Hessian check for 2-parameter problems#363
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #363 +/- ##
===========================================
+ Coverage 99.08% 99.19% +0.10%
===========================================
Files 52 59 +7
Lines 3605 4333 +728
===========================================
+ Hits 3572 4298 +726
- Misses 33 35 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I think we should continue with the slightly low coverage (98%) - the Hessian check is missing a test on the case where the optimal point is a saddle point for which we would need a relevant optimisation problem (this relates to #391). |
BradyPlanden
left a comment
Member
There was a problem hiding this comment.
Thanks @NicolaCourtier, a few suggestions/comments
BradyPlanden
approved these changes
Dec 20, 2024
BradyPlanden
left a comment
Member
There was a problem hiding this comment.
LGTM - just one suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
classify_using_Hessianfunction that can assess the identifiability of an optimisation result and return an informative message to the user.Issue reference
Fixes #362.
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.