Updates to likelihoods, bug fix GaussianLogLikelihood class#338
Merged
Conversation
…t values, updt non-bounded parameter logic, bugfix pints.CMAES construction
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #338 +/- ##
===========================================
+ Coverage 97.60% 97.72% +0.12%
===========================================
Files 42 42
Lines 2459 2502 +43
===========================================
+ Hits 2400 2445 +45
+ Misses 59 57 -2 ☔ View full report in Codecov by Sentry. |
…ss likelihoods, move MAP
GaussLogLikelihood classGaussianLogLikelihood class
…hood, aligns tests
…dd default and arg for parameter boundary multiplier, adds tests
BradyPlanden
commented
Jun 7, 2024
15 tasks
Member
|
Hi @BradyPlanden, thanks for working on this issue! I have tried adding |
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
NicolaCourtier
approved these changes
Jul 5, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Great work, thanks @BradyPlanden! I left a few small comments but the implementation looks good overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GaussianLogLikelihoodfor use with all optimisers,GaussianLogLikelihoodto integration testing,CMAESconstruction wherex0is destroyed.MAPto _likelihoods.pyIssue reference
Fixes #257
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.