Install seed packages (setuptools and wheel)#317
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #317 +/- ##
========================================
Coverage 95.80% 95.80%
========================================
Files 38 38
Lines 2048 2048
========================================
Hits 1962 1962
Misses 86 86 ☔ View full report in Codecov by Sentry. |
|
Just triggered a workflow run on my fork just to see if this is working as intended, let's hope it passes: https://github.com/agriyakhetarpal/PyBOP/actions/runs/9006940642 Edit: okay, the tests that were failing earlier are the same, and the test suite is proceeding to run. This is now okay to merge, I suppose. |
BradyPlanden
left a comment
There was a problem hiding this comment.
Thanks for the bugfix @agriyakhetarpal. We need to do a bit more on either hyper-parameter tuning or loosening of the assertions so that the scheduled tests pass consistently, but this is a step in the right direction!
Description
This PR is a small update to
noxfile.pywhere thenoxconfiguration is updated to install seed packages that can be sometimes missing fromuv's virtual environments (if usingnox[uv]). These packages are installed withnox, which usesvirtualenvas the backend for creating virtual environments, and therefore this is a failsafe change to ensure that PyBaMM can be installed along with PyBOP for platforms where wheels are not available (macOS ARM wheels started to become available with PyBaMM v24.1).Issue reference
This change hopes to fix some of the failing scheduled tests: https://github.com/pybop-team/PyBOP/actions/runs/8999338828
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.