Decrease test suite completion time#304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #304 +/- ##
===========================================
- Coverage 95.80% 95.70% -0.10%
===========================================
Files 38 38
Lines 2048 2048
===========================================
- Hits 1962 1960 -2
- Misses 86 88 +2 ☔ View full report in Codecov by Sentry. |
|
The patch coverage for this PR has decreased because we don't have a direct test for the SciPyMinimize |
|
Just noticed that this PR fixes the scheduled tests, too. If you feel that this can take time for reviewing and merging, I wish to point towards #308, which fixes them as well. |
agriyakhetarpal
left a comment
There was a problem hiding this comment.
Thanks, @BradyPlanden! The difference in the test suite completion time seems to be noticeable. Could you add a CHANGELOG entry as well?
|
@all-contributors add @agriyakhetarpal to review. |
|
I've put up a pull request to add @agriyakhetarpal! 🎉 |
Description
This PR updates the test suite to minimise the completion time while maintaing the performance assertions.
Issue reference
Fixes #302
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s doctestYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.