Add Maximum a Posteriori (MAP)#275
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #275 +/- ##
========================================
Coverage 95.47% 95.48%
========================================
Files 36 36
Lines 2011 2036 +25
========================================
+ Hits 1920 1944 +24
- Misses 91 92 +1 ☔ View full report in Codecov by Sentry. |
2 tasks
NicolaCourtier
approved these changes
Apr 11, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Just one comment from my side, thanks @BradyPlanden, nice addition!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a MAP cost function with corresponding tests. This cost function has required arguments for the
problemclass as well as thelikelihoodclass, this allows the MAP class to be agnostic to the likelihood defined as it constructs the class on initialisation.This PR also updates the codecov job on the
test_on_pushworkflow to v4 with additional options.Issue reference
Fixes #248 #277
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s docsYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.