Switch to softprops/action-gh-release to upload artifacts for GitHub Releases#268
Conversation
|
I'll make a separate PR for the Anaconda nightlies, since it would require a bit of cleanup for the conditions in the workflow across all jobs. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #268 +/- ##
===========================================
+ Coverage 95.35% 95.42% +0.07%
===========================================
Files 36 36
Lines 1979 1990 +11
===========================================
+ Hits 1887 1899 +12
+ Misses 92 91 -1 ☔ View full report in Codecov by Sentry. |
BradyPlanden
left a comment
There was a problem hiding this comment.
This looks good, thanks @agriyakhetarpal.
After the problems with the last release, it would be great to verify this workflow. Any thoughts on how we can go about doing that? Perhaps the nightly releases will give us that capability.
|
Yes, thanks, @BradyPlanden—I see that you already merged this—please let me know what you think the best way to proceed will be. I think the |
Description
This PR updates the
publish-to-pypijob to upload thesigstore-generated signatures to the accompanying GitHub Release. These files were absent in the v24.3 release, which renders verifying the PyBOP wheel and the source distribution a tad difficult. Some other changes have been included as a part of small cleanups.Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s docsYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.