Increment PyBaMM > 23.5#252
Merged
BradyPlanden merged 7 commits intoApr 18, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
========================================
Coverage 95.49% 95.49%
========================================
Files 38 38
Lines 2040 2040
========================================
Hits 1948 1948
Misses 92 92 ☔ View full report in Codecov by Sentry. |
…integration tests in parameterisation tests
BradyPlanden
force-pushed
the
251-bug-scheduled-test-failing-on-pybamm-235
branch
from
April 8, 2024 16:48
c445aff to
c7ef869
Compare
…est-failing-on-pybamm-235' into 251-bug-scheduled-test-failing-on-pybamm-235
agriyakhetarpal
approved these changes
Apr 18, 2024
agriyakhetarpal
left a comment
Member
There was a problem hiding this comment.
Thanks, @BradyPlanden! Just a few comments.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Increments PyBaMM > 23.5 to ensure
pybamm.Theveninis usable within PyBOP and fixes the current failing scheduled tests.Issue reference
Fixes #251
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests$ nox -s docsYou can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.