Add BPX support - #246
Merged
Merged
Conversation
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #246 +/- ##
===========================================
+ Coverage 95.35% 95.42% +0.07%
===========================================
Files 36 36
Lines 1979 1990 +11
===========================================
+ Hits 1887 1899 +12
+ Misses 92 91 -1 ☔ View full report in Codecov by Sentry. |
BradyPlanden
left a comment
Member
There was a problem hiding this comment.
Thanks for the addition @NicolaCourtier, on a whole this looks great! I've made two small comments that are worth investigating before merging. Let me know what you think.
BradyPlanden
approved these changes
Apr 2, 2024
BradyPlanden
left a comment
Member
There was a problem hiding this comment.
Thank @NicolaCourtier.
LGTM, just one suggestion on the unit tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for importing BPX JSON files as parameter sets.
Issue reference
Adds feature request #79.
Type of change