Add PEP517/518 pyproject.toml support#203
Merged
BradyPlanden merged 9 commits intoFeb 19, 2024
Merged
Conversation
agriyakhetarpal
commented
Feb 16, 2024
agriyakhetarpal
commented
Feb 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #203 +/- ##
========================================
Coverage 94.57% 94.58%
========================================
Files 44 44
Lines 1826 1829 +3
========================================
+ Hits 1727 1730 +3
Misses 99 99 ☔ View full report in Codecov by Sentry. |
BradyPlanden
approved these changes
Feb 19, 2024
BradyPlanden
left a comment
Member
There was a problem hiding this comment.
Excellent, thanks for the contribution @agriyakhetarpal! Just one spot that's worth updating.
Co-Authored-By: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the key changes in this PR are as follows:
ruffandpytestconfigurations are included in the newly-addedpyproject.tomldistutilsis deprecated, so I removed thesetup.pyshim file altogether considering that PyBOP in itself is a pure-Python packagepybop.versionas a private sub-module forpybop– this ensures that no one importspybop.version.__version__since the correct and intended way is through accessingpybop.__version__, which is unchanged except for the fact that the version is now defined inpyproject.toml; the good thing about this is that the package will now not have to be imported viaimport pybopto parse the version stringP.S. I should perhaps look at doing point 4 for PyBaMM too.