Additions to #177#198
Merged
BradyPlanden merged 26 commits intoMar 19, 2024
Merged
Conversation
…ackets from plots as per SI standard, quick plot for varying length signals, add pybop.is_numeric and restore design cost exception for optimisation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 177-plotting-capabilities #198 +/- ##
=============================================================
- Coverage 94.61% 94.19% -0.43%
=============================================================
Files 35 36 +1
Lines 1857 1997 +140
=============================================================
+ Hits 1757 1881 +124
- Misses 100 116 +16 ☔ View full report in Codecov by Sentry. |
…y. Update tests, add base model classes to init, cleaner multi-signal interaction
…er tests, dict output observer.evaluate()
…version due to breaking change in 8.1.0
… Discharge capacity as default additional_variable
…icode, add infeasible unit test
Datatype restructure for optimisation objects
…ptimisers, pass optimiser final cost as is
NicolaCourtier
approved these changes
Mar 18, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Looks ready to merge once the coverage is passing, thanks very much @BradyPlanden!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the following:
DEFAULT_SUBPLOT_TRACE_OPTIONSvariablepybop.is_numericfunction for checking input valuesEncompasses #224. This PR is also a step towards fixing our current failing scheduled tests.