Add fitting functionality for geometric parameters#169
Merged
Conversation
…ebuilding, updt. plot2D
…s, add rebuild parameters functionality to problem.evaluate(), updt. example
3 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #169 +/- ##
===========================================
+ Coverage 94.58% 94.70% +0.11%
===========================================
Files 44 44
Lines 1829 1887 +58
===========================================
+ Hits 1730 1787 +57
- Misses 99 100 +1 ☔ View full report in Codecov by Sentry. |
… change private reference to public in design example
…arameter cls, bigfix geometric logic in problem cls
Member
Author
|
Hi @NicolaCourtier, this should now be ready for review. I've updated the spm_CMAES.py example to be geometric as a reference. Seems to be working fine, and isn't a massive hit on performance. |
Member
|
Did you mean to change |
NicolaCourtier
approved these changes
Feb 20, 2024
NicolaCourtier
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks @BradyPlanden, don't forget the Changelog!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to fit geometric parameters in pybop. This essentially requires a model rebuild every iteration, but a combined effort to minimise the number of objects that get rebuilt. It completes the following:
rebuild()method tobase_modelmodel.rebuild_parametersset_rebuild_parameters()to create the required dictionary of geometric parameterscopy()method tobase_modelplot_cost2D()Closes #18