Skip to content

Add StandaloneProblem#153

Merged
NicolaCourtier merged 10 commits into
developfrom
151-standalone-problem
Jan 25, 2024
Merged

Add StandaloneProblem#153
NicolaCourtier merged 10 commits into
developfrom
151-standalone-problem

Conversation

@NicolaCourtier

Copy link
Copy Markdown
Member
  • Add StandaloneProblem to examples
  • Move StandaloneCost in same folder
  • Add test for Standalon Problem

@NicolaCourtier NicolaCourtier linked an issue Dec 18, 2023 that may be closed by this pull request
@codecov

codecov Bot commented Dec 18, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c3438ab) 94.07% compared to head (3682569) 94.05%.
Report is 3 commits behind head on develop.

❗ Current head 3682569 differs from pull request most recent head 7392620. Consider uploading reports for the commit 7392620 to get more accurate results

Files Patch % Lines
examples/standalone/problem.py 92.85% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
- Coverage    94.07%   94.05%   -0.03%     
===========================================
  Files           36       37       +1     
  Lines         1351     1379      +28     
===========================================
+ Hits          1271     1297      +26     
- Misses          80       82       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolaCourtier NicolaCourtier marked this pull request as draft December 18, 2023 17:42
@NicolaCourtier NicolaCourtier marked this pull request as ready for review December 18, 2023 18:31

@BradyPlanden BradyPlanden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @NicolaCourtier.

Looking into the future, I think we will want to provide a nicer interface to construct standalone problem and cost classes.

Edit: Can you update the Changelog as well?

@NicolaCourtier NicolaCourtier merged commit 2e35380 into develop Jan 25, 2024
@NicolaCourtier NicolaCourtier deleted the 151-standalone-problem branch January 25, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Standalone Problem

2 participants