Avoid C style casts in the docs, at least for pointers#2487
Merged
Conversation
Contributor
|
Thanks! |
fefd594 to
c8b2720
Compare
Why only for pointers? Because C casts are hard to grep for.
YannickJadoul
approved these changes
Sep 14, 2020
YannickJadoul
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @bstaletic!
henryiii
approved these changes
Sep 14, 2020
Collaborator
|
Let's just get this in before we forget. If there are more places where we can find C-style casts, we can always create more PRs :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When C++14, and thus
py::overload_cast, isn't available the docs suggest a C style cast. A conservativestatic_castseems a much better idea when working with function pointers.EDIT: Let's hope I caught all C casts in the docs.