fix: add missing signature#2363
Conversation
|
I was about to say "Isn't that because it's a constructor from Maybe do the same for the |
|
Someone told me when I found this a while back it was probably just an oversight, but I don't know where that conversation was. |
f3cc16d to
dd9f742
Compare
|
By the way, buffer info is information about the data, but it does not contain ownership information. The handle contains ownership information, so you can be sure the owning object is not destroyed while the array is still present. The other constructors support this, it's just missing from the direct buffer info constructor. |
|
Alright; |
rwgk
left a comment
There was a problem hiding this comment.
Looks good to me!
I spent a few minutes looking in the nump.h sources, this change seems super safe to me.
All the other array constructors have an optional handle, but this one was missing.