Skip to content

travis: Ensure Python 3.8 is used, disable failing PyPy 2.7 build#2160

Closed
EricCousineau-TRI wants to merge 3 commits into
pybind:masterfrom
EricCousineau-TRI:issue-2159
Closed

travis: Ensure Python 3.8 is used, disable failing PyPy 2.7 build#2160
EricCousineau-TRI wants to merge 3 commits into
pybind:masterfrom
EricCousineau-TRI:issue-2159

Conversation

@EricCousineau-TRI

@EricCousineau-TRI EricCousineau-TRI commented Apr 9, 2020

Copy link
Copy Markdown
Collaborator

Resolves #2159

Lemme know if I should take out the disabling of PyPy.

Thanks to @carlsonmark for the help!


This change is Reviewable

@EricCousineau-TRI

Copy link
Copy Markdown
Collaborator Author

Nuts... seems like Sphinx upgrade to 3.0.0, which breaks things?

@wjakob

wjakob commented Apr 26, 2020

Copy link
Copy Markdown
Member

Looks good, but let's definitely not drop tests if there is only a single one covering that flavor of interpreter. Can you amend this PR with the fix for Python 3.8?

@wjakob

wjakob commented Jun 30, 2020

Copy link
Copy Markdown
Member

Hi @EricCousineau-TRI -- sorry for taking a while to respond to this PR.
First, I'd like to double-check: can this be closed now, or is it still applicable? (given that some improvements to CI have recently landed, like a38e533)

@EricCousineau-TRI

Copy link
Copy Markdown
Collaborator Author

Yup! I can close it!

But just to check, I looked at a few PRs, and they only had an AppVeyor status (no TravisCI status):
#2260
#2265

Is that expected? (and would you like that to be a separate issue?)

@wjakob

wjakob commented Jul 1, 2020

Copy link
Copy Markdown
Member

I noticed that too. Something (not me, did not touch) recently messed up the integration. Earlier today, I removed all the permissions and recreated them. I'm hoping that bumping those PRs will fix cause all of the CI to rebuilt. Note that Travis itself is unaffected, you can log in there and see all of the builds.

@EricCousineau-TRI

Copy link
Copy Markdown
Collaborator Author

Awesome, sound great - closing now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Travis Job for Python 3.8 on Linux does not actually run Python 3.8?

2 participants