Skip to content

Conversation

@Rishab87
Copy link
Member

@Rishab87 Rishab87 commented Aug 15, 2025

Description

Added helper functions to import external 3D meshes generated from other tools or libraries which can be solved in PyBaMM. This can help users get high quality meshes from other libraries which we can't directly support in PyBaMM due to licensing issues.

Note: I've only tested it for .msh, .xdmf file formats which are the most commonly used ones. But it may support several others.

Related to #5104

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Rishab87 Rishab87 requested a review from a team as a code owner August 15, 2025 06:55
Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @Rishab87 !

@codecov
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

❌ Patch coverage is 93.23308% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.86%. Comparing base (4a875e9) to head (7fc6801).
⚠️ Report is 159 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/meshes/scikit_fem_submeshes_3d.py 93.23% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5162      +/-   ##
===========================================
- Coverage    98.89%   98.86%   -0.03%     
===========================================
  Files          320      320              
  Lines        26435    26568     +133     
===========================================
+ Hits         26142    26266     +124     
- Misses         293      302       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rishab87 can you improve the coverage then this is g2g

@Rishab87
Copy link
Member Author

@rtimms I've ensured coverage I think it should be fine now, can you re-review it?

@Rishab87 Rishab87 requested a review from rtimms August 18, 2025 15:43
@rtimms rtimms merged commit e154fec into pybamm-team:develop Aug 19, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants