-
-
Notifications
You must be signed in to change notification settings - Fork 728
Added load_mesh_from_file function to support external 3D meshes.
#5162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…load-external-meshes
…changning name of submesh
rtimms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks @Rishab87 !
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5162 +/- ##
===========================================
- Coverage 98.89% 98.86% -0.03%
===========================================
Files 320 320
Lines 26435 26568 +133
===========================================
+ Hits 26142 26266 +124
- Misses 293 302 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rtimms
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rishab87 can you improve the coverage then this is g2g
|
@rtimms I've ensured coverage I think it should be fine now, can you re-review it? |
Description
Added helper functions to import external 3D meshes generated from other tools or libraries which can be solved in PyBaMM. This can help users get high quality meshes from other libraries which we can't directly support in PyBaMM due to licensing issues.
Note: I've only tested it for
.msh,.xdmffile formats which are the most commonly used ones. But it may support several others.Related to #5104
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests