-
-
Notifications
You must be signed in to change notification settings - Fork 728
Unified entry point for models and parameter sets #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified entry point for models and parameter sets #4490
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4490 +/- ##
========================================
Coverage 99.10% 99.10%
========================================
Files 306 307 +1
Lines 23671 23686 +15
========================================
+ Hits 23458 23473 +15
Misses 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arjxn-py
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start @santacodes, looks like this is still a WIP? Still I have commented just a tip hoping it'd make sense.
There are some conflicts that you may want to resolve and also feel free to add [WIP] prefix to your PR title while you're on it.
faa78bc to
164f71e
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
8a90a9b to
8da0b01
Compare
|
@santacodes Are you still working on this? |
Yes I am, it has yet to be reviewed, I will update this branch and request a review again. |
f06b1a1 to
b662073
Compare
b662073 to
298e306
Compare
|
Still shows "Merging is blocked" :( I think it needs an approval from @kratman and @valentinsulzer as they have requested changes above. |
Co-authored-by: Eric G. Kratz <[email protected]>
Head branch was pushed to by a user without write access
4a15d8c
Head branch was pushed to by a user without write access
6b05386
Description
Modified the existing
parameter_setsAPI and unified entry points to accommodatemodel entry points. This is an extension of the existing model entry points in thepybamm-cookieproject. Relevant discussion.Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: