Skip to content

Conversation

@santacodes
Copy link
Member

@santacodes santacodes commented Oct 4, 2024

Description

Modified the existing parameter_sets API and unified entry points to accommodate model entry points. This is an extension of the existing model entry points in the pybamm-cookie project. Relevant discussion.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all (or $ nox -s tests)
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

You can run integration tests, unit tests, and doctests together at once, using $ python run-tests.py --quick (or $ nox -s quick).

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.10%. Comparing base (56450f8) to head (6b05386).
⚠️ Report is 176 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4490   +/-   ##
========================================
  Coverage    99.10%   99.10%           
========================================
  Files          306      307    +1     
  Lines        23671    23686   +15     
========================================
+ Hits         23458    23473   +15     
  Misses         213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start @santacodes, looks like this is still a WIP? Still I have commented just a tip hoping it'd make sense.

There are some conflicts that you may want to resolve and also feel free to add [WIP] prefix to your PR title while you're on it.

@santacodes santacodes changed the title Unified entry point for models and parameter sets [WIP] Unified entry point for models and parameter sets Oct 11, 2024
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@santacodes santacodes changed the title [WIP] Unified entry point for models and parameter sets Unified entry point for models and parameter sets Nov 10, 2024
@kratman
Copy link
Contributor

kratman commented Jan 8, 2025

@santacodes Are you still working on this?

@santacodes
Copy link
Member Author

@santacodes Are you still working on this?

Yes I am, it has yet to be reviewed, I will update this branch and request a review again.

@santacodes santacodes force-pushed the modelentrypoints branch 3 times, most recently from f06b1a1 to b662073 Compare March 7, 2025 06:36
@santacodes santacodes closed this Mar 7, 2025
@santacodes santacodes reopened this Mar 7, 2025
Saransh-cpp
Saransh-cpp previously approved these changes Jul 3, 2025
@Saransh-cpp
Copy link
Member

Still shows "Merging is blocked" :(

I think it needs an approval from @kratman and @valentinsulzer as they have requested changes above.

@Saransh-cpp Saransh-cpp enabled auto-merge (squash) July 3, 2025 21:22
agriyakhetarpal
agriyakhetarpal previously approved these changes Jul 4, 2025
@kratman kratman dismissed their stale review July 8, 2025 13:58

Changes made

Co-authored-by: Eric G. Kratz <[email protected]>
auto-merge was automatically disabled July 8, 2025 15:51

Head branch was pushed to by a user without write access

@santacodes santacodes dismissed stale reviews from Saransh-cpp and agriyakhetarpal via 4a15d8c July 8, 2025 15:51
agriyakhetarpal
agriyakhetarpal previously approved these changes Jul 8, 2025
@agriyakhetarpal agriyakhetarpal enabled auto-merge (squash) July 8, 2025 16:22
Saransh-cpp
Saransh-cpp previously approved these changes Jul 8, 2025
auto-merge was automatically disabled July 11, 2025 15:37

Head branch was pushed to by a user without write access

@santacodes santacodes dismissed stale reviews from Saransh-cpp and agriyakhetarpal via 6b05386 July 11, 2025 15:37
@valentinsulzer valentinsulzer merged commit 687adc4 into pybamm-team:develop Jul 11, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants