Skip to content

fix not actually targeting anything :P #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
protocol-1903 merged 1 commit into from
Sep 2, 2025
Merged

fix not actually targeting anything :P #449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions scripts/programmable-inserter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,10 +144,6 @@ local function update_targets(inserter)
-- set new target and proper inventory target index
entity.proxy_target_entity = target
entity.proxy_target_inventory = proxy_targets[target.type][metadata[index .. "_inventory"]]
-- else -- either no target exists or target inventory is not valid for that entity
-- inserter[index] = nil -- make inserter act normal
-- entity.proxy_target_entity = nil -- remove entity reference from proxy
-- entity.proxy_target_inventory = proxy_targets.default[metadata[index .. "_inventory"]] -- save the desired type for later
end
end
end
Expand Down Expand Up @@ -306,6 +302,8 @@ py.on_event(defines.events.on_gui_selection_state_changed, function (event)
metadata[element.name].destroy()
metadata[element.name] = nil
metadata[element.name .. "_inventory"] = nil
-- set target entity
inserter[element.name] = nil
-- remove from storage if neither exists
if not metadata.drop_target and not metadata.pickup_target then
storage.programmable_inserters[inserter.unit_number] = nil
Expand All @@ -319,6 +317,8 @@ py.on_event(defines.events.on_gui_selection_state_changed, function (event)
force = inserter.force,
position = inserter[element.name:sub(1, -7) .. "position"]
}
-- set target entity
inserter[element.name] = metadata[element.name]

storage.programmable_inserters[inserter.unit_number] = metadata
update_targets(inserter)
Expand Down Expand Up @@ -397,16 +397,10 @@ py.on_event(defines.events.on_player_setup_blueprint, function (event)
-- if non existant, cancel
if not blueprint then return end
local entities = blueprint and blueprint.get_blueprint_entities()
if not entities then return; end
if not entities then return end
-- update entities
for i, entity in pairs(entities) do
-- if fake underground, remove from blueprint
if xutil.is_type.psuedo(entity) then
entities[i] = nil
-- if psuedo pipe to ground, replace with normal variant
elseif xutil.is_pipe(entity) then
entity.name = xutil.get_type.base(entity)
end
-- add tags and remove proxy inventories as necessary
end
blueprint.set_blueprint_entities(entities)
end)
Expand All @@ -429,4 +423,4 @@ if script.active_mods["bobinserters"] then
end)
end

]]
--]]