feat(cli): add --revision option to most CLI commands #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --revision option to the download, apply, and benchmark CLI commands, allowing users to specify which revision of a pretrained pipeline to use from HuggingFace Hub. The changes also improve parameter handling by making token and cache optional where appropriate.
Key changes:
- Added
--revisionoption todownload,apply, andbenchmarkcommands - Made
tokenandcacheparameters optional (changed from required toOptional[...]withNonedefaults) - Cleaned up formatting inconsistencies (whitespace removal, inline comments alignment)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/pyannote/audio/main.py | Added --revision parameter to three CLI commands (download, apply, benchmark), made token and cache optional, reordered parameters for consistency, and cleaned up formatting/whitespace |
| CHANGELOG.md | Documented the new feature in the changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.