RxJava 2 support

[geralt-encore]

Any thoughts about how to introduce it in a better manner without dropping RxJava 1 support?
Also object methods have to be reworked since they are emitting null if there is no requested object.

[geralt-encore]

Totally forgot about Maybe - it's perfect for that case.

[artem-zinnatullin]

Yeah, there is some work required to do RxJava v2 support.

TL;TR plan:

1. Wait for final release.
2. Add basic support for Flowable because it supports backpressure which is
   required for IO operations.
3. Add support for Single/Completable.
4. Add/Think about support for Maybe.

RxJava 2 can work with RxJava 1 in same classpath, so I don't see problems
with that except naming of the methods (I think we'll just add "2" to it).

On 2 Oct 2016 10:30 am, "Ilya Zorin" notifications@github.com wrote:

Totally forgot about Maybe - it's perfect for that case.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#685 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7B3FCuyaL5AWs-sb4gOL3psnCF8K3Pks5qv8ABgaJpZM4KHoyr
.

[geralt-encore]

Not sure if I understand you correctly, so you want to have both RxJava and RxJava 2 in the same library? It sounds not really good having both of these dependencies when you need only one of them in your project.
Regarding supporting Maybe - it's a perfect fit for object methods since null is prohibited in RxJava 2 and was kinda hacky in a first place.

[nikitin-da]

StorIO has just provided rxjava dependency - you can use rx only when you already have this dependency in your project

[geralt-encore]

Thanks for clarification @nikitin-da!
Anyway, I will be happy to help with this task.

[artem-zinnatullin]

Great, let's wait for release then :)

On 3 Oct 2016 5:00 am, "Ilya Zorin" notifications@github.com wrote:

Thanks for clarification @nikitin-da https://github.com/nikitin-da!
Anyway, I will be happy to help with this task.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#685 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA7B3LHi2oPNnNQosC_7eDxso5pEMCCMks5qwMQlgaJpZM4KHoyr
.

[geralt-encore]

https://github.com/ReactiveX/RxJava/releases/tag/v2.0.0

[artem-zinnatullin]

Yup, still waiting for more stable build though, but we can start migration.

[skrugly]

Good reason to lay the foundation for StorIO v2, huh?

[artem-zinnatullin]

Hah, probably, but we're using semantic versioning so StorIO will become v2 as soon as we break API, adding RxJava v2 is planned as non-breaking change at the moment, so I guess StorIO will still be v1.

BUT: I'd like to keep both RxJava v1 and v2 only for the period of migration (in our internal and yours, users's) apps from RxJava v1 to v2 and when we'll see that RxJava v1 is not actively used anymore -> we'll drop support for RxJava v1 and that'll in fact require us to upgrade major version of StorIO!

@Adambl4 @nikitin-da @geralt-encore sounds good to you?

[nikitin-da]

I agree, both versions will be required for a certain period of time

[geralt-encore]

Sounds good 👍

[artem-zinnatullin]

Though I admit that with https://github.com/akarnokd/RxJava2Interop from @akarnokd we can leave only RxJava v2 support and force users to use interop library to convert types between v1 and v2, but without extension methods support in plain Java it'll be non-fluent and add a lot of boilerplate to the code.