Fix encoding/decoding issue of UserInfo#41
Conversation
|
This issue raised when I adopted the encoding part from go as it's most straight forward, the one from node is way to cryptic |
36809fe to
b13ab20
Compare
Before this PR one couldn't use `:` or `@` in username or password now it's possible. To achieve this representation of UserInfo changed to record instead of just string as we need to encode username and password separately (without "connecting" `:`)
b13ab20 to
fe53954
Compare
|
The problem with this approach is it assumes the userinfo stuff has a particular structure, which is not necessarily the case - what we have here is the most common case, but according to the spec, the format in there has no specific grammar (aside from the allowable characters). There is some problem here though, probably just we should do percent encode/decode, since the grammar is: |
|
will be fixed in #43 |
Uh oh!
There was an error while loading. Please reload this page.