Skip to content

Conversation

@cognifloyd
Copy link
Contributor

Allow users to annotate the deployments created by the pulp-operator.

Closes #1190

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2024

Hi @cognifloyd. Thanks for your PR.

I'm waiting for a pulp member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Allow users to annotate the deployments created by the pulp-operator.

closes pulp#1190
@cognifloyd cognifloyd force-pushed the deployment_annotations branch from 394366d to dc5abb2 Compare January 18, 2024 17:22
@dkliban
Copy link
Member

dkliban commented Jan 18, 2024

/ok-to-test

Copy link
Collaborator

@git-hyagi git-hyagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!
Thank you for the contribution!

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cognifloyd, git-hyagi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@git-hyagi
Copy link
Collaborator

git-hyagi commented Jan 18, 2024

note for future me: remember to notify in the changelog/release notes that this and #1193 will/can restart pulpcore pods, so we recommend upgrading in a maintenance window to avoid downtime.

@cognifloyd
Copy link
Contributor Author

cognifloyd commented Jan 18, 2024

note for future me: remember to notify in the changelog/release notes that this and #1193 will restart pulpcore pods, so we recommend upgrading in a maintenance window to avoid downtime.

Do you want me to update the changelog entry here?

@git-hyagi
Copy link
Collaborator

Do you want me to update the changelog entry here?

Yes, please :D
Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFE] Allow annotating deployments

3 participants