Fix regression with S3 endpoint#1065
Conversation
|
Hi @StopMotionCuber. Thanks for your PR. I'm waiting for a pulp member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
d6d5dbc to
0dc6140
Compare
|
hi @StopMotionCuber, /ok-to-test Can you please add a CHANGES/1066.bugfix file with a changelog update? |
0dc6140 to
ebd89b1
Compare
|
Have done so. Thanks for the pointer, was a bit lost on the correct procedure for the changelog entry |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: git-hyagi, StopMotionCuber The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your contribution!
If your PR needs a changelog entry:
If not, please add
[noissue]to your commit messageI detected an issue with this code being deleted in 09cd16a, probably unintentionally. It breaks our custom S3 endpoint, so I'd like to bring it back