Skip to content

Fix regression with S3 endpoint#1065

Merged
openshift-merge-robot merged 1 commit intopulp:mainfrom
StopMotionCuber:fix_s3_endpoint
Aug 25, 2023
Merged

Fix regression with S3 endpoint#1065
openshift-merge-robot merged 1 commit intopulp:mainfrom
StopMotionCuber:fix_s3_endpoint

Conversation

@StopMotionCuber
Copy link
Copy Markdown
Contributor

Thank you for your contribution!

If your PR needs a changelog entry:

If not, please add [noissue] to your commit message

I detected an issue with this code being deleted in 09cd16a, probably unintentionally. It breaks our custom S3 endpoint, so I'd like to bring it back

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 25, 2023

Hi @StopMotionCuber. Thanks for your PR.

I'm waiting for a pulp member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@git-hyagi
Copy link
Copy Markdown
Collaborator

hi @StopMotionCuber,

/ok-to-test
Good catch! Thank you!

Can you please add a CHANGES/1066.bugfix file with a changelog update?

@StopMotionCuber
Copy link
Copy Markdown
Contributor Author

Have done so.

Thanks for the pointer, was a bit lost on the correct procedure for the changelog entry

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: git-hyagi, StopMotionCuber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1ddd1a8 into pulp:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants