Add signing-service as an argument to repository creation and updation#227
Open
balasankarc wants to merge 1 commit intopulp:mainfrom
Open
Add signing-service as an argument to repository creation and updation#227balasankarc wants to merge 1 commit intopulp:mainfrom
balasankarc wants to merge 1 commit intopulp:mainfrom
Conversation
Author
|
@quba42 @bmbouter I am not exactly sure how to handle |
Author
4593c2c is my way of implementing it. WDYT? |
4593c2c to
3596388
Compare
1042978 to
7c71bd3
Compare
7c71bd3 to
10a1995
Compare
10a1995 to
06b6653
Compare
Author
|
@quba42 Can you take a look? Thanks. |
Member
|
It might help to add some testing to see that it works. |
closes pulp#54 Signed-off-by: Balasankar 'Balu' C <balu@dravidam.net>
06b6653 to
334afd2
Compare
Author
@mdellweg Agreed. I added some tests, inspired from pulp-cli. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes to #54
Implements
--signing-serviceargument topulp deb repository createcommand.