Merged
Conversation
Contributor
Lynx005F
commented
Jun 10, 2024
- Added fault detection only voters
- Added single-line voting macros
- Macros instantiate voter cells (so they could easily be replaced with technology-specific cells)
- Macros automatically uniquely name underlying voter cells
- Macros usable with bender unclude
- Added testbenches for above functionality
- Updated README.md accordingly
…some cells needed for voters).
d57c1e1 to
bccb2a9
Compare
9a0cbbd to
42be33b
Compare
added 2 commits
June 11, 2024 15:13
- Updated licence - Added $fatal for unsupported replicas - Made parameterizable voter macros have explicit parameter. - Updated README.md
214a2a3 to
726ac10
Compare
Contributor
Author
|
I managed to also fix the enum errors that previously needed to be supressed by using an index into an array. Now all enums with >1 bit width work without errors, but Enums with 1 bit only are now unsupported (I think it is fine as one can just use logic instead). |
micprog
requested changes
Jun 18, 2024
Member
micprog
left a comment
There was a problem hiding this comment.
I found a few more minor issues, some more critical than others.
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
…uration and set fault_any to 0 when unused.
Contributor
Author
|
IMO we can squash all comits without loosing any relevant history |
Lynx005F
added a commit
to Lynx005F/redundancy_cells
that referenced
this pull request
Nov 4, 2024
* Added voter macros which automatically instantiate unique cells (and some cells needed for voters). Co-authored-by: Maurus Item <itemm@student.ethz.ch> Co-authored-by: Michael Rogenmoser <michael@rogenmoser.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.