Conversation
Re-converges with ptr727/ProjectTemplate develop (issue #176 follow-ups, upstream cde3354/f526b55/402e862): hardened Copilot runbook, consolidated CODESTYLE.md (General + .NET, Python dropped), .NET task casing + dependsOrder, PR smoke artifact skip, .editorconfig comments, AGENTS.md re-sync guidance. CI lint backstop doc corrected to husky-run.
Contributor
There was a problem hiding this comment.
Pull request overview
Promotes develop to main for a template re-sync, updating repo-wide guidance/docs, VS Code + Husky task naming, and PR smoke build behavior (skip artifact packaging/upload) without changing library functionality.
Changes:
- Consolidates/updates
CODESTYLE.mdand related guidance inAGENTS.md/.github/copilot-instructions.mdto match the template’s “General + droppable language sections” model. - Normalizes
.NETtask casing across VS Code (tasks.json,launch.json) and Husky (.husky/task-runner.json), and enforces sequential task dependency ordering. - Adds a
smokeinput tobuild-nugetlibrary-task.ymland forwards it frombuild-release-task.ymlto skip artifact zip/upload during PR smoke builds.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CODESTYLE.md |
Reworked into “General” + “.NET” sections; updates clean-compile, linting, and suppression guidance. |
AGENTS.md |
Updates template re-sync guidance, including explicit carry rules for clean-compile tasks. |
.vscode/tasks.json |
Renames .Net* tasks to .NET*, adds sequential dependency ordering, and clarifying comments. |
.vscode/launch.json |
Updates preLaunchTask to match the .NET Build task label. |
.husky/task-runner.json |
Renames Husky task .Net Format to .NET Format for consistent casing. |
.github/workflows/build-release-task.yml |
Forwards smoke into the NuGet build reusable workflow to support smoke-mode behavior. |
.github/workflows/build-nugetlibrary-task.yml |
Introduces smoke input and gates zip/upload steps on !smoke to reduce PR artifact usage. |
.github/copilot-instructions.md |
Re-sync/hardening + updated pointers to consolidated code-style guidance. |
.editorconfig |
Updates Json/JsonC comment and adds suppression-policy guidance comment for .NET section. |
…ving (#184) Conform LanguageTagTests.cs to the new CODESTYLE no-#pragma rule: CA1508 via [SuppressMessage], CS8602 via the null-forgiving operator (compiler diagnostics can't use [SuppressMessage]). No #pragma remain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintenance promotion of
developtomain(merge-commit per the main ruleset). No functional change and noversion.jsonbump -mainadvances only its NBGV height.Carries the single develop commit since the last promotion:
.github/copilot-instructions.md(verbatim from template, placeholders re-adapted)CODESTYLE.mdinto General + .NET sections (Python section dropped, droppable per-language model); CI lint backstop corrected todotnet husky run.NETtask casing +dependsOrder: sequenceacrosstasks.json/launch.json/.husky/task-runner.jsonbuild-nugetlibrary-task.yml+build-release-task.yml).editorconfigJson/JsonC + suppression-policy comments (now template-identical)AGENTS.mdre-sync guidance updated to the droppable-section model + tasks.json carry noteReviewed on #182 (two Copilot rounds: one doc fix applied, one finding declined with rationale).