Fix tag-pinning doc to pin target_commitish to GitCommitId#181
Merged
Conversation
Addresses the Copilot review on the develop->main promotion (#180): revert the version.json 1.2->1.3 minor bump so the maintenance promotion carries the current floor (no functional change in this batch), and correct the AGENTS.md 'Tag pinning on releases' bullet to pin target_commitish to NBGV's GitCommitId - matching the live build-release-task.yml and the upstream template - instead of the misleading github.sha.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts project versioning and documentation to address review feedback from the develop→main promotion workflow, aligning written guidance with the repository’s actual release/tagging implementation.
Changes:
- Reverts
version.json’s NBGV version floor from1.3to1.2. - Updates
AGENTS.mdrelease-tag pinning guidance to explicitly require pinningtarget_commitishto the exact built commit SHA (via NBGVGitCommitId), rather thangithub.sha.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
version.json |
Changes the NBGV version floor. |
AGENTS.md |
Clarifies release tag pinning guidance to match the branch-matrix publisher behavior. |
Undo the 1.2 revert: 1.3.x pre-releases (e.g. 1.3.6) are already published, so reverting the floor to 1.2 would regress the version line below them. The promotion releases 1.3.x stable on main, monotonic forward from both 1.2.66 and the published 1.3.x. This PR now carries only the AGENTS.md tag-pinning doc fix.
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects the AGENTS.md "Tag pinning on releases" bullet to pin
target_commitishto NBGV'sGitCommitId, notgithub.sha. The live build-release-task.yml already pins GitCommitId (github.sha is wrong for the publisher's branch matrix), matching the upstream template. Addresses a finding from the develop->main promotion review (#180). version.json stays at 1.3 (1.3.x is already published).