Re-sync from upstream template and move API rules into AGENTS.md#179
Merged
Conversation
Re-syncs the verbatim carries and adapted docs against ProjectTemplate develop (upstream PR #167): adds the .NET-only marker to .editorconfig; updates AGENTS.md with the new versioning policy (no develop-ahead / no post-release bump), the Comments and Line Endings rules, the artifact-retention convention, and a Staying in Sync section; and re-syncs the Copilot review runbook in copilot-instructions.md (GraphQL requestReviews, REST/GraphQL login fix). Sets retention-days: 1 on the intermediate build artifact and trims historic narrative and rule citations from workflow comments (logic, CRLF, and SHA pins unchanged). Moves the library's API-design rules and contract notes into AGENTS.md (new Library API Conventions section) so every agent reads them, and slims copilot-instructions.md back to the narrow provider-mechanics shape. Also updates the workspace recommended-extensions list. Addresses #176.
Contributor
There was a problem hiding this comment.
Pull request overview
Re-syncs this repository’s operational/docs baseline with the upstream template guidance, consolidating public API contract rules into AGENTS.md and trimming workflow comments while keeping workflow behavior intact. This keeps repo-wide rules discoverable for all agents and reduces CI artifact storage footprint.
Changes:
- Consolidate and update repository rules in
AGENTS.md, including a new “Library API Conventions” section and refreshed versioning guidance. - Re-sync
.github/copilot-instructions.mdto focus on Copilot-specific mechanics (including GraphQL-based re-request guidance) plus a brief commit/PR title summary. - Add
retention-days: 1for intermediate workflow artifacts and trim workflow comment blocks (no logic changes intended beyond retention).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| LanguageTags.code-workspace | Updates recommended TODO-tree extension entry in the workspace configuration. |
| AGENTS.md | Updates branch/release/docs rules and adds “Library API Conventions” + template-sync guidance. |
| .github/workflows/test-pull-request.yml | Comment-only trimming/clarification for PR test workflow behavior. |
| .github/workflows/run-periodic-codegen-pull-request.yml | Comment-only trimming for schedule/concurrency rationale. |
| .github/workflows/run-codegen-pull-request-task.yml | Comment-only trimming clarifying matrix/PR behavior. |
| .github/workflows/publish-release.yml | Comment-only trimming clarifying publish model and concurrency rationale. |
| .github/workflows/merge-bot-pull-request.yml | Comment-only trimming for the merge-bot model and pull_request_target rationale. |
| .github/workflows/get-version-task.yml | Comment-only trimming/refresh around the dotnet/nbgv@master exception. |
| .github/workflows/build-release-task.yml | Comment-only trimming clarifying pinning to GitCommitId and publish behavior. |
| .github/workflows/build-nugetlibrary-task.yml | Sets intermediate artifact retention-days: 1 (functional CI/storage change) and trims comments. |
| .github/copilot-instructions.md | Re-syncs Copilot runbook mechanics and removes repo/API-contract duplication now housed in AGENTS.md. |
| .editorconfig | Adds a clear “.NET-only below” marker before the C# / ReSharper section. |
Re-syncs the ptr727/ProjectTemplate develop update that resolves the upstream clarification: AGENTS.md (intro and the Staying in Sync verbatim-carry note) states that project-specific conventions and API contracts live in AGENTS.md, not .github/copilot-instructions.md, which stays narrow. Hardens the Copilot review runbook (and the Expected Review Loop) for the case where Copilot completes a review with no inline comments - a clean pass, not a missing review - and notes that round 1 is auto-seeded and should be polled for before self-triggering, with an issue-comment fallback for reading the bot node id.
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-converges with
ptr727/ProjectTemplatedevelop (upstream PR #167) per the heads-up in #176, adapted to this repo's NuGet-library shape.Verbatim carries and docs
.editorconfig: add the.NET-onlymarker before the[*.cs]block (the C#/ReSharper block is carried here).AGENTS.md: drop the develop-ahead / post-release-bump versioning framing; add the Comments house-rule, Line Endings note, markdown trailing-\rule, theretention-days: 1workflow convention, and aStaying in Sync with the Templatesection (report drift upstream; no sibling-repo names / no downstream registry)..github/copilot-instructions.md: re-sync the Copilot review runbook to the current template (GraphQLrequestReviews, REST vs GraphQL reviewer-login[bot]fix, mutation-based retry); drop the stale## Versioningblock.Project-rule consolidation
AGENTS.md(newLibrary API Conventionssection) so every agent reads them, not just Copilot/VS Code; slim.github/copilot-instructions.mdback to the narrow provider-mechanics shape. Upstream clarification filed as ptr727/ProjectTemplate#173.Workflows
retention-days: 1on the intermediate build artifact inbuild-nugetlibrary-task.yml.merge-upstream-versionjob is intentionally not added.Out of scope
AGENTS.mdand the.ymlworkflows are stored LF though.editorconfigmandates CRLF) is left untouched per the "don't reflow endings" rule; a deliberate EOL-only normalization can follow separately.Verification
dotnet build: 0 warnings / 0 errors.dotnet test: 257/257 pass.Addresses #176.
🤖 Generated with Claude Code