Skip to content

Rename CODEGEN_APP_ID references to CODEGEN_APP_CLIENT_ID#136

Merged
ptr727 merged 2 commits into
developfrom
fix-app-secret-name
May 12, 2026
Merged

Rename CODEGEN_APP_ID references to CODEGEN_APP_CLIENT_ID#136
ptr727 merged 2 commits into
developfrom
fix-app-secret-name

Conversation

@ptr727

@ptr727 ptr727 commented May 12, 2026

Copy link
Copy Markdown
Owner

The GitHub App credential secret is stored as CODEGEN_APP_CLIENT_ID in both Actions and Dependabot stores, but the workflows that landed in #130 referenced CODEGEN_APP_ID (the template's name). With the wrong name, actions/create-github-app-token gets an empty app-id and the merge-bot + codegen fail on first invocation. actions/create-github-app-token v1.12+ accepts either an App ID or a Client ID at the app-id input, so this is a pure secret-lookup fix.

The GitHub App credential secret is stored as `CODEGEN_APP_CLIENT_ID` in both the Actions and Dependabot stores, but the workflows landed referencing `CODEGEN_APP_ID` (the template's name). With the wrong name, `actions/create-github-app-token` would get an empty `app-id` and the merge-bot + codegen would fail on first invocation. `actions/create-github-app-token` v1.12+ accepts either a numeric App ID or a Client ID at the `app-id` parameter, so the rename is purely a secret-lookup fix.
Copilot AI review requested due to automatic review settings May 12, 2026 20:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes GitHub Actions workflow secret lookup for the GitHub App credential by renaming CODEGEN_APP_ID references to CODEGEN_APP_CLIENT_ID, ensuring actions/create-github-app-token receives a non-empty identifier and the merge-bot/codegen workflows can authenticate correctly.

Changes:

  • Rename the reusable codegen workflow’s required secret from CODEGEN_APP_ID to CODEGEN_APP_CLIENT_ID and update token generation input usage.
  • Update merge-bot workflow token generation steps to read secrets.CODEGEN_APP_CLIENT_ID.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/run-codegen-pull-request-task.yml Updates required secret name and create-github-app-token input to use CODEGEN_APP_CLIENT_ID.
.github/workflows/merge-bot-pull-request.yml Updates all create-github-app-token steps to use CODEGEN_APP_CLIENT_ID.

Comment thread .github/workflows/run-codegen-pull-request-task.yml
Copilot review on PR #136: README's repository setup section still referenced the old `CODEGEN_APP_ID` secret name. Sync to match the renamed workflow references and note that the underlying value is a Client ID (the action accepts either form).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants