WIP: Make Brotli support enabled by default, if appropriate urllib3 version is available#5554
Closed
gdubicki wants to merge 1 commit into
Closed
WIP: Make Brotli support enabled by default, if appropriate urllib3 version is available#5554gdubicki wants to merge 1 commit into
gdubicki wants to merge 1 commit into
Conversation
gdubicki
commented
Aug 9, 2020
by the urllib3 version (>= 1.25.1) and brotli package being present
68b45df to
1278959
Compare
Contributor
Author
|
Ping! :) |
Member
|
FYI Requests already supports Brotli via urllib3: import requests
http = requests.Session()
http.headers = {"Accept-Encoding": "br"}
resp = http.request("GET", "https://cloudflare.com")
print(resp.text)
print("Content-Encoding:", resp.headers["Content-Encoding"]) |
Contributor
Author
|
@sethmlarson : yes, I know. Please see the updated PR title. I hope my intent is more clear now. :) |
Contributor
|
At #5783 I took a different approach: rely on urllib3 to determine whether to include |
Contributor
Author
|
Closing in favor of #5783. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is still a work in progress - I have to make sure that the tests are actually running, not skipped every time 😅 but I would like to get feedback if the direction is right.
I had to update some deps to make the tests pass after a lot of packages being updated after I added
brotlito dev-packages. But I assume that this should be done anyway. Especially as there were discrepancies in the versions - f.e.pytestversion insetup.pycommit message declared v. 4 compatibility while the version inPipenvwas set to be at most v. 3.10.1.Speaking of dependencies I have a doubt how to declare required urllib3 version. Technically the first with brotli support is 1.25.1, but this is a version not supported by Requests... Should I update all the references to require urllib3 >= 1.25.2 then instead of >= 1.25.1?