Don't use the cache if the request has a Range header#328
Merged
frostming merged 1 commit intopsf:masterfrom Feb 2, 2024
dimbleby:range-disables-cache
Merged
Don't use the cache if the request has a Range header#328frostming merged 1 commit intopsf:masterfrom dimbleby:range-disables-cache
frostming merged 1 commit intopsf:masterfrom
dimbleby:range-disables-cache
Conversation
woodruffw
approved these changes
Feb 1, 2024
Member
woodruffw
left a comment
There was a problem hiding this comment.
Thanks @dimbleby, LGTM. I'll let @frostming review as well before merging.
(Also, thanks for adding a test!)
Contributor
|
Looks good for now. I think we would have to encode headers as well as the URL as the cache key. |
Member
Makes sense! @dimbleby: Do you need a point release for this fix? If so, I can prep one tonight. |
Contributor
I think so, we can cut a |
Contributor
Author
|
thanks folks! |
woodruffw
pushed a commit
to woodruffw-forks/cachecontrol
that referenced
this pull request
Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #327