v8: avoid unnecessary log level checks. #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's mostly a pedantic change, but it slightly improves performance in microbenchmarks. Benchmark Diff -------------------------------------------------------------------- WasmSpeedTest_empty -0.0891 WasmSpeedTest_get_current_time -0.0424 WasmSpeedTest_small_string -0.0507 WasmSpeedTest_small_string1000 -0.0118 WasmSpeedTest_small_string_check_compiler -0.0556 WasmSpeedTest_small_string_check_compiler1000 +0.0041 WasmSpeedTest_large_string -0.0322 WasmSpeedTest_large_string1000 -0.0311 WasmSpeedTest_get_property -0.0173 WasmSpeedTest_grpc_service -0.0558 WasmSpeedTest_grpc_service1000 -0.0021 WasmSpeedTest_modify_metadata +0.0410 WasmSpeedTest_modify_metadata1000 -0.0298 WasmSpeedTest_json_serialize +0.0009 WasmSpeedTest_json_deserialize +0.0028 WasmSpeedTest_json_deserialize_empty -0.0028 WasmSpeedTest_convert_to_filter_state -0.0172 Signed-off-by: Piotr Sikora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's mostly a pedantic change, but it slightly improves performance
in microbenchmarks.
Benchmark Diff
WasmSpeedTest_empty -0.0891
WasmSpeedTest_get_current_time -0.0424
WasmSpeedTest_small_string -0.0507
WasmSpeedTest_small_string1000 -0.0118
WasmSpeedTest_small_string_check_compiler -0.0556
WasmSpeedTest_small_string_check_compiler1000 +0.0041
WasmSpeedTest_large_string -0.0322
WasmSpeedTest_large_string1000 -0.0311
WasmSpeedTest_get_property -0.0173
WasmSpeedTest_grpc_service -0.0558
WasmSpeedTest_grpc_service1000 -0.0021
WasmSpeedTest_modify_metadata +0.0410
WasmSpeedTest_modify_metadata1000 -0.0298
WasmSpeedTest_json_serialize +0.0009
WasmSpeedTest_json_deserialize +0.0028
WasmSpeedTest_json_deserialize_empty -0.0028
WasmSpeedTest_convert_to_filter_state -0.0172
Signed-off-by: Piotr Sikora [email protected]