fix(torghut): fail closed on legacy parity projections#12876
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6eefa8d4d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 036d382c1c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex address the unresolved current-head review feedback end to end. Guard the historical-version membership check with |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b53f0b369a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Codex couldn't complete this request. Try again later. |
5cef0b0 to
6bbfcf0
Compare
6bbfcf0 to
474a999
Compare
Summary
projection_versionvalues withEconomicLedgerErrorinstead of an unhandledTypeErrormainRelated Issues
Remediates the unresolved Codex findings on #12766 and #12778 and the actionable findings introduced on this remediation PR.
Testing
env LD_LIBRARY_PATH=/workspace/runtime-libs .venv/bin/pytest tests/economic_ledger/test_legacy_parity_payload_version.py tests/economic_ledger/test_tigerbeetle_parity.py -q(14 passed)Rollout
This changes the Torghut runtime image and status semantics. After merge, the image build, immutable digest promotion, Argo sync, migration/smoke hooks, current workload readiness, restarts, logs,
/trading/status, and post-deploy verification must be checked before source threads are resolved.Breaking Changes
Legacy or malformed persisted parity projections now fail closed as stale/unavailable instead of being accepted or raising an unhandled exception.
Checklist