Skip to content

fix(torghut): fail closed on legacy parity projections#12876

Merged
gregkonush merged 1 commit into
mainfrom
codex/review-remediation-legacy-parity-status
Jul 21, 2026
Merged

fix(torghut): fail closed on legacy parity projections#12876
gregkonush merged 1 commit into
mainfrom
codex/review-remediation-legacy-parity-status

Conversation

@gregkonush

@gregkonush gregkonush commented Jul 20, 2026

Copy link
Copy Markdown
Member

Summary

  • treat persisted legacy TigerBeetle parity projections as stale and unsatisfied rather than as valid current evidence
  • fail closed on malformed non-string projection_version values with EconomicLedgerError instead of an unhandled TypeError
  • document that parity is derived from the same canonical economic reducer while independently validating persisted projection evidence
  • add focused regressions for legacy versions, malformed versions, and current-version parity
  • replace the prior patch-runner head with direct source commits rebased onto current main

Related Issues

Remediates the unresolved Codex findings on #12766 and #12778 and the actionable findings introduced on this remediation PR.

Testing

  • env LD_LIBRARY_PATH=/workspace/runtime-libs .venv/bin/pytest tests/economic_ledger/test_legacy_parity_payload_version.py tests/economic_ledger/test_tigerbeetle_parity.py -q (14 passed)
  • Ruff format and lint passed on all changed Python files
  • complete required GitHub CI remains blocking before merge

Rollout

This changes the Torghut runtime image and status semantics. After merge, the image build, immutable digest promotion, Argo sync, migration/smoke hooks, current workload readiness, restarts, logs, /trading/status, and post-deploy verification must be checked before source threads are resolved.

Breaking Changes

Legacy or malformed persisted parity projections now fail closed as stale/unavailable instead of being accepted or raising an unhandled exception.

Checklist

  • Testing section documents exact commands and results.
  • Screenshots are not applicable; Breaking Changes is filled in.
  • Documentation and rollout requirements are updated.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6eefa8d4d8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/review-remediation.patch Outdated
Comment thread .github/review-remediation.patch Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 036d382c1c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread services/torghut/app/trading/economic_ledger/tigerbeetle_parity.py Outdated

Copy link
Copy Markdown
Member Author

@codex address the unresolved current-head review feedback end to end. Guard the historical-version membership check with isinstance(projection_version, str) so non-scalar sealed values reach strict validation and fail with EconomicLedgerError, keep unknown/future versions strict, preserve the v1/v2 stale-unsatisfied behavior and documentation correction, add or retain focused regressions for both cases, run the relevant Torghut gates, and push the fix to this PR branch.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b53f0b369a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/review-remediation.patch Outdated
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex couldn't complete this request. Try again later.

@gregkonush
gregkonush force-pushed the codex/review-remediation-legacy-parity-status branch from 5cef0b0 to 6bbfcf0 Compare July 21, 2026 05:34
@gregkonush
gregkonush marked this pull request as draft July 21, 2026 05:35
@gregkonush
gregkonush marked this pull request as ready for review July 21, 2026 05:35
@gregkonush
gregkonush force-pushed the codex/review-remediation-legacy-parity-status branch from 6bbfcf0 to 474a999 Compare July 21, 2026 05:44
@gregkonush
gregkonush merged commit 9af9361 into main Jul 21, 2026
19 checks passed
@gregkonush
gregkonush deleted the codex/review-remediation-legacy-parity-status branch July 21, 2026 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant