use lsblk to figure out if a device is partition or not#105
Merged
Conversation
Right now we have very crude logic to figure out if a device is partition or not. It fails on some devices whose names end with a number. Use lsblk instead to figure out if a device is partition or not. Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Collaborator
Author
Member
|
LGTM. |
Collaborator
Author
|
Cool. Merging. |
rhvgoyal
added a commit
that referenced
this pull request
Mar 1, 2016
use lsblk to figure out if a device is partition or not
|
I tried to build a raid0 and pass it as a device, and it failed this check. Do you know if that would have worked otherwise? I used a command like:
After this completed I passed /dev/md0 into the container-storage-setup (actually docker-storage-setup). It failed on this check
Thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99
Right now we have very crude logic to figure out if a device is partition
or not. It fails on some devices whose names end with a number. Use lsblk
instead to figure out if a device is partition or not.
Signed-off-by: Vivek Goyal vgoyal@redhat.com